Increase sync size to 1s to avoid hitting 429 too many requests issue#21
Increase sync size to 1s to avoid hitting 429 too many requests issue#21madjarevicn wants to merge 87 commits intoflashbots:mainfrom
Conversation
* Add remote relay connection for getting validator data * Add block submission to remote relay * Adjust readme
* Add block build trigger from beacon node * remove empty block building Co-authored-by: avalonche <avvalonche@protonmail.com>
* fix issue with geth not shutting down (flashbots#97) * Add eth_callBundle rpc method (flashbots#14) * flashbots: add eth_estimateGasBundle (flashbots#102) * feat(ethash): flashbots_getWork RPC with profit (flashbots#106) * Calculate megabundle as soon as it's received (flashbots#112) * Add v0.5 specification link (flashbots#118)
flashbots#123) * Discard reverting megabundle blocks and head change interrupted blocks * Discard all blocks with incomplete bundles * Run reverting megabundles regression test separately from bundle tests
* Fix duplicate relay registrations in cache * Remove Timestamp from builder validation data as it should be ignored * Adjust cfg.SecondaryRemoteRelayEndpoints for empty list Co-authored-by: Mateusz Morusiewicz <11313015+Ruteri@users.noreply.github.com>
|
You probably want to change this |
| builderSigningDomain: builderSigningDomain, | ||
|
|
||
| limiter: rate.NewLimiter(rate.Every(time.Millisecond), 510), | ||
| limiter: rate.NewLimiter(rate.Every(time.Millisecond), 600), |
There was a problem hiding this comment.
I think 510 is enough above 500 to avoid issues most of the time for relays wanting 2 blocks/s
I think the bigger problem we could try to solve is that some relays limit to 1 block/s and we'd want the rate limit to be configurable in that case
|
|
||
| // resubmits block builder requests every second | ||
| runRetryLoop(ctx, 500*time.Millisecond, func() { | ||
| runRetryLoop(ctx, 1*time.Second, func() { |
There was a problem hiding this comment.
This should not impact the relay rate limit, as it's a loop scheduling new blocks and not a loop controlling how often they are submitted
Again, would be nice to make it either dynamic based on load or configurable - changing from one hardcoded value to another won't bring much benefit
Updated docker file COPY path.
| value := new(boostTypes.U256Str) | ||
| err = value.FromBig(block.Profit) | ||
|
|
||
| log.Info("Block profit for block", value) |
There was a problem hiding this comment.
It has to be log.Info("message", "value name", value) otherwise it will print errors.
|
Fyi, the rate limit is now 450 blocks / 5 minutes, so the appropriate internal limit works be 3 block submissions within 2 seconds. |
14 participants
📝 Summary
Increased a delay from 0.5s to 1s in order to avoid hitting rate limit on flashbots api.
📚 References
CONTRIBUTING.md